<div dir="ltr"><div>Thanks,</div><div> </div><div>I later learned that there is already an MR for fixing this issue, by Florian Muellner. </div></div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 30, 2019 at 11:37 PM suzuki toshiya <<a href="mailto:mpsuzuki@hiroshima-u.ac.jp">mpsuzuki@hiroshima-u.ac.jp</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">According to the commit log when FT_PIXEL_MODE_BGRA was introduced to FreeType, <a href="https://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=760d342d37ec9b26420956e3421075d410571b65" rel="noreferrer" target="_blank">https://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=760d342d37ec9b26420956e3421075d410571b65</a> FT_LOAD_COLOR macro (which we can test its availability by #ifdef) was introdcued at the same time. So replacing "#ifdef FT_PIXEL_MODE_BGRA" by "#ifdef FT_LOAD_COLOR" would resolve this bug. Just I've submitted a merge request: <a href="https://gitlab.freedesktop.org/cairo/cairo/merge_requests/25/diffs" rel="noreferrer" target="_blank">https://gitlab.freedesktop.org/cairo/cairo/merge_requests/25/diffs</a> Sincerely I apologize the trouble I caused, and thank to Matthias for finding this. I cannot thank you enoughly. Regards, mpsuzuki suzuki toshiya wrote: > Dear Matthias, > > Ahhh, I'm quite sorry. Using "ifdef" is not good to check the availability of > FT_PIXEL_MODE_BGRA. > This is an integer value declared as > > typedef enum FT_Pixel_Mode_ > { > FT_PIXEL_MODE_NONE = 0, > FT_PIXEL_MODE_MONO, > FT_PIXEL_MODE_GRAY, > FT_PIXEL_MODE_GRAY2, > FT_PIXEL_MODE_GRAY4, > FT_PIXEL_MODE_LCD, > FT_PIXEL_MODE_LCD_V, > FT_PIXEL_MODE_BGRA, > > FT_PIXEL_MODE_MAX /* do not remove */ > > } FT_Pixel_Mode; > > #ifdef is not good. Soon I would post a fix for that, by better configure script. > > Regardss, > mpsuzuki > > suzuki toshiya wrote: >> Dear Mattias, >> >> Maybe this commit? >> >> <a href="https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcgit.freedesktop.org%2Fcairo%2Fcommit%2F%3Fid%3Dc0ed8ce1a111cb9472aef080ac3aa31526443f7c&data=02%7C01%7Cmpsuzuki%40hiroshima-u.ac.jp%7Cc9dd36ca27c4496b21a308d6e5747ea5%7Cc40454ddb2634926868d8e12640d3750%7C1%7C0%7C636948685861037983&sdata=VzneUcB3sA50zMDep3IEji2yI4Sw%2BAsv2xK9s92mrow%3D&reserved=0" rel="noreferrer" target="_blank">https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcgit.freedesktop.org%2Fcairo%2Fcommit%2F%3Fid%3Dc0ed8ce1a111cb9472aef080ac3aa31526443f7c&data=02%7C01%7Cmpsuzuki%40hiroshima-u.ac.jp%7Cc9dd36ca27c4496b21a308d6e5747ea5%7Cc40454ddb2634926868d8e12640d3750%7C1%7C0%7C636948685861037983&sdata=VzneUcB3sA50zMDep3IEji2yI4Sw%2BAsv2xK9s92mrow%3D&reserved=0</a> >> >> Sorry, please let me know more about your trouble. >> >>> This breaks color Emoji support since the freetype headers don't define this. >> If so, and if we revert this, following "case FT_PIXEL_MODE_BGRA" would cause a compilation error? >> >> Regards, >> mpsuzuki >> >> On 2019/05/31 2:09, Matthias Clasen wrote: >>> Some recent commit introduced an >>> >>> #ifdef FT_PIXEL_MODE_BGRA >>> >>> This breaks color Emoji support since the freetype headers don't define this. >>> >>> Please revert >>> -- cairo mailing list <a href="mailto:cairo@cairographics.org" target="_blank">cairo@cairographics.org</a> <a href="https://lists.cairographics.org/mailman/listinfo/cairo" rel="noreferrer" target="_blank">https://lists.cairographics.org/mailman/listinfo/cairo</a></blockquote></div>