<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<font size="+1">Hello,<br>
<br>
Referring to my previous patch :</font><a
class="moz-txt-link-freetext"
href="https://lists.cairographics.org/archives/cairo/2020-August/029019.html">https://lists.cairographics.org/archives/cairo/2020-August/029019.html</a>
<div class="moz-cite-prefix">I have replaced this with other patch
on my local computes (see the attachment).<br>
Basically, I have removed function
_cairo_image_surface_is_size_valid() and all code related to it.<br>
The reason? pixman library makes such tests every time.<br>
Let them decide what is valid and what not.<br>
<br>
Regards,<br>
Stanislaw Jesmanowicz<br>
<br>
On 7/24/21 10:52 AM, Uli Schlachter wrote:<br>
</div>
<blockquote type="cite"
cite="mid:fce69bc2-ca1f-ee96-0da3-9339669b33eb@znc.in">
<pre class="moz-quote-pre" wrap="">Hi again,
Am 24.07.21 um 10:24 schrieb Uli Schlachter:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Am 23.07.21 um 23:29 schrieb ChameleonScales:
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">[...]
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Otherwise could the source code be easily edited to make a custom build of Cairo with an increased limit?
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Well, not easily, I guess.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">I just remembered that there might be a way: [0]
If I understand this mail correctly, just dropping this check works good
enough for some cases. So, if you want to make a custom build, you could
just apply the patch from [0] and see what happens.
Note that I do not have much trust in this patch. Subtle example: The
patch from that mail multiplies two ints and then casts the result to
uint64_t. Any integer overflows would already happen before the cast.
Cheers,
Uli
[0]: <a class="moz-txt-link-freetext" href="https://lists.cairographics.org/archives/cairo/2020-August/029019.html">https://lists.cairographics.org/archives/cairo/2020-August/029019.html</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="100">--
__________________________________________________________
Stanislaw Jesmanowicz stan <at> mail2 <dot> jesmanowicz <dot> com
</pre>
</body>
</html>