<div dir="ltr">Hi Tobias,<div><br></div><div>Sounds like unintentinally committed indeed. I created an issue to fix this:</div><div><br></div><div>  <a href="https://gitlab.freedesktop.org/cairo/cairo/-/issues/534">https://gitlab.freedesktop.org/cairo/cairo/-/issues/534</a></div><div><br></div><div>Doing git blame... later... actually that return looks intentional, if poorly indented and not committed:</div><div><br></div><div>  <a href="https://gitlab.freedesktop.org/cairo/cairo/-/commit/2d1a137f3d27b60538c58b25e867288c7b0b61bc">https://gitlab.freedesktop.org/cairo/cairo/-/commit/2d1a137f3d27b60538c58b25e867288c7b0b61bc</a></div><div><br></div><div><br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature">behdad<br><a href="http://behdad.org/" target="_blank">http://behdad.org/</a></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 11, 2022 at 10:34 AM Tobias Fleischer (reduxFX) <<a href="mailto:tobias.fleischer@reduxfx.com">tobias.fleischer@reduxfx.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif">I just noticed that between Cairo release 1.17.2 and 1.17.4, a suspicious looking always return line was added in function _cairo_clip_reduce_to_boxes() on line 526 in file cairo-clip-boxes.c :</div><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">1.17.2:</div><div class="gmail_default" style="font-family:tahoma,sans-serif">static cairo_clip_t *<br>_cairo_clip_reduce_to_boxes (cairo_clip_t *clip)<br>{<br>    struct reduce r;<br>    cairo_clip_path_t *clip_path;<br>    cairo_status_t status;<br><br>    if (clip->path == NULL)<br>      return clip;<br>...<br><br>1.17.4<br>static cairo_clip_t *<br>_cairo_clip_reduce_to_boxes (cairo_clip_t *clip)<br>{<br>    struct reduce r;<br>    cairo_clip_path_t *clip_path;<br>    cairo_status_t status;<br><br>  return clip;<br>    if (clip->path == NULL)<br>        return clip;<br>...</div><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">The additional return before the if condition practically skips the whole function.</div><div class="gmail_default" style="font-family:tahoma,sans-serif">Is this intentional?</div><div class="gmail_default" style="font-family:tahoma,sans-serif">Best,</div><div class="gmail_default" style="font-family:tahoma,sans-serif">Toby</div><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div></div>
</blockquote></div>