]PATCH 2/3] Do not ignore resources being registered
David Miller
davem at davemloft.net
Sun May 3 20:51:48 PDT 2009
From: Tiago Vignatti <vignatti at freedesktop.org>
Date: Sun, 03 May 2009 23:12:33 -0300
> In post-pciaccess Xorg, we were ignoring the lists of resources
> registered. Let the userspace application control it again and put the
> application aware of multiple PCI resources.
>
> Signed-off-by: Tiago Vignatti <vignatti at freedesktop.org>
Corrupted like the other patches by your email client, but
also:
> +static resList
> +xf86GetResourcesImplicitly(int entityIndex)
> +{
> + if (entityIndex >= xf86NumEntities) return NULL;
Please put the return on a new line and properly give it
indentation.
> +
> + switch (xf86Entities[entityIndex]->bus.type) {
> + case BUS_ISA:
> + case BUS_NONE:
> + case BUS_SBUS:
> + return NULL;
Return statement missing proper indentation.
> + case BUS_PCI:
> + return GetImplicitPciResources(entityIndex);
Again.
> + case BUS_last:
> + return NULL;
Here too.
> + if (!list) return NULL;
Return statement on new line with proper indentation, please.
More information about the xorg-devel
mailing list