[PATCH 00/12] Cygwin/X: Various patches
Colin Harrison
colin.harrison at virgin.net
Sun May 24 07:18:20 PDT 2009
First look...more checks to follow.
1/12, 3/12, 5/12 OK
7/12 OK but one opportunity to use the cached CLIPBOARD atom missed in
winclipboardwndproc.c
@@ -399,17 +341,11 @@
/* Reassert ownership of the CLIPBOARD */
iReturn = XSetSelectionOwner (pDisplay,
- XInternAtom (pDisplay,
- "CLIPBOARD",
- False),
+ atomClipboard,
iWindow,
CurrentTime);
-
if (iReturn == BadAtom || iReturn == BadWindow ||
- XGetSelectionOwner (pDisplay,
- XInternAtom (pDisplay,
- "CLIPBOARD",
- False)) != iWindow)
+ XGetSelectionOwner (pDisplay, atomClipboard) != iWindow)
{
winErrorFVerb (1, "winClipboardWindowProc - WM_DRAWCLIPBOARD - "
"Could not reassert ownership of CLIPBOARD\n");
Thanks
Colin
More information about the xorg-devel
mailing list