[cairo-bugs] [Bug 48320] User interface controls drawn using cairo are missing right-most pixel column

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Apr 19 14:57:27 PDT 2012


Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Chris Wilson <chris at chris-wilson.co.uk> 2012-04-19 14:57:27 PDT ---
I think I have this fixed, albeit accidentally. And I think the fix is:

commit 9417fec04a172a7c44be38c1b3d032c3fee4f0d6
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Wed Apr 18 20:44:43 2012 +0100

    image: Split inline SRC composition

    Currently we construct a mask for the entire line and try to process it
    in one call to pixman (two without the LERP operator). An alternative
    approach is split the row into separate composite operations for the
    clear (which we can skip), fully opaque and partial spans.

    As the source operator is typically mostly opaque or clear, this is a
    good win as we are able to utilise more fast paths. In the worst case,
    it degrades to the old method of constructing a whole mask for a row.
    It may reduce performance for having to process lots of spans though
    (this is where the pixman spans interface should help). However, such
    geometry is rare and typically handled elsewhere.

    And the existing code has a bug where it was clearing the destination
    for clear regions of the mask outside of the spans.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.

More information about the cairo-bugs mailing list