[cairo-bugs] [Bug 84908] Compilation errors with MSVC after recent changes to 'cairo-path-stroke-traps.c'

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Nov 13 01:42:03 PST 2014


https://bugs.freedesktop.org/show_bug.cgi?id=84908

Fan, Chun-wei <fanc999 at yahoo.com.tw> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fanc999 at yahoo.com.tw

--- Comment #5 from Fan, Chun-wei <fanc999 at yahoo.com.tw> ---
Comment on attachment 107945
  --> https://bugs.freedesktop.org/attachment.cgi?id=107945
Another variant to solve the msvc compilation problem

Hi,

I can confirm too that this patch works for me (Visual Studio 2008+, which also
gets this problem).  The issue here is that Visual Studio 2005+ is quite strict
on type conversions (so it wants code to be clear enough on conversions), and I
think it makes sense from a correctness and a security point of view.  Although
the code might not look that nice, but I think as Hans mentioned, it is
consistent with the rest of Cairo.

Please consider this patch, especially as Cairo does need some update and work
on the Windows side, and making it buildable with Visual Studio would be really
helpful for that work.

Thanks very much for your time, with blessings!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cairographics.org/archives/cairo-bugs/attachments/20141113/bdfc8e60/attachment.html>


More information about the cairo-bugs mailing list