[cairo-bugs] [Bug 84569] Quartz backend build failure (git master)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=84569

--- Comment #4 from Andrea Canciani <ranma42 at gmail.com> ---
(In reply to ~suv from comment #2)
> Remaining error with patch applied:
> 
>   CC       cairo-quartz-image-surface.lo
> cairo-quartz-image-surface.c:382:11: error: implicit declaration of function
> '_cairo_surface_is_quartz' is invalid in C99
>       [-Werror,-Wimplicit-function-declaration]
>     if (! _cairo_surface_is_quartz (surface)) {
>           ^
> 1 error generated.
> make[3]: *** [cairo-quartz-image-surface.lo] Error 1
> 
> 
> 
> Compiler (from Xcode 4.3.2):
> 
> $ clang --version
> Apple clang version 3.1 (tags/Apple/clang-318.0.58) (based on LLVM 3.1svn)

Oops, I did not realize that the issue also affected quartz-image (I was
building with default flags, which do not enable it).

(In reply to Bryce Harrington from comment #3)
> Andrea, you're on the right path, that's half the fix.
> 
> For the remaining error(s) suv reported, do this:
> 
> 1. _cairo_surface_is_quartz() needs to not be static, since it's used in
> another file.
> 
> 2.  Move the declaration of _cairo_surface_is_quartz() into the
> cairo-quartz-private.h header.  Define it as cairo_private like other
> routines listed here.

Did this in
http://cgit.freedesktop.org/~ranma42/cairo/commit/?id=84c68269f7e24ebaf9bf02702feeb775a5bac53e

I also let it run through the testsuite and (besides from some reference images
that might need to be updated) it looks mostly good (except for a couple of
blend modes... will investigate those).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cairographics.org/archives/cairo-bugs/attachments/20141003/96618918/attachment.html>