[cairo-bugs] [Bug 83359] New: Should define all disabled features as 0 to avoid build failure

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=83359

          Priority: medium
            Bug ID: 83359
          Assignee: chris at chris-wilson.co.uk
           Summary: Should define all disabled features as 0 to avoid
                    build failure
        QA Contact: cairo-bugs at cairographics.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: julien.isorce at gmail.com
          Hardware: Other
            Status: NEW
           Version: 1.12.16
         Component: general
           Product: cairo

Created attachment 105566
  --> https://bugs.freedesktop.org/attachment.cgi?id=105566&action=edit
build: define no features as 0

Currently in cairo-gl.h there is:
#if CAIRO_HAS_GL_SURFACE || CAIRO_HAS_GLESV2_SURFACE

When building cairo with --disable-glesv2 then the compiler warns that
CAIRO_HAS_GLESV2_SURFACE is not defined.
If those warnings are treated as errors then the build just fails (ex: webkit)

The attached patch ensure all stuffs under put in NO_FEATURES are defined as 0,
even for features defaulted to "no". Because currently only features defaults
to auto or yes are put into NO_FEATURES when disabled.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cairographics.org/archives/cairo-bugs/attachments/20140901/f6fdcf76/attachment.html>