[cairo-bugs] [Bug 73580] cairo-perf-trace failure

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=73580

--- Comment #16 from Emanuele Aina <emanuele.aina at collabora.com> ---
Created attachment 111958
  --> https://bugs.freedesktop.org/attachment.cgi?id=111958&action=edit
[PATCH 3/3] cairo-trace: Extract common helper for
_surface_create_similar[_image]()

To avoid any divergence between cairo_surface_create_similar_image() and
cairo_surface_create_similar() in future, coalesce the code to emit the
trace line in a common helper.

Unfortunately the signature of the two trace lines are slightly
different (in 'similar' the content type precedes width and height,
while for 'similar-image' width and height come before the format
identifier), but to be able to run new traces with older cairo tools it
cannot be changed.

This is optional, I still included it in the patchset since I feel that the two
implementations may drift again after this resync, leading to subtle bugs.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cairographics.org/archives/cairo-bugs/attachments/20150108/19ea0778/attachment.html>