[cairo-bugs] [Bug 89339] util/cairo-script: compilation errors on AIX (no member named '__jmpbuf')

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89339

Bryce Harrington <b.harrington at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #2 from Bryce Harrington <b.harrington at samsung.com> ---
In studying bug 89354, and googling around for best practices in order of
header inclusion, there seems to be a rough concensus[1] that you should
include in this order:

Given foo.c:
1.  "config.h"
2.  "foo.h"
3.  headers from the same component
4.  headers from other components
5.  system headers

The rationale here is to avoid hidden dependencies between headers.

For comparison, Google's coding style guide[2] swaps #3 and #5, arguing that
this ensures that build breaks show up first for people working on the files in
question, not for people in other projects.

Poking around Cairo .c files, the first form seems to be the more common
convention.  I think in the interest of consistency we should stick with that
form.

But looking at the original problem, maybe header shuffling is the wrong way to
solve this.  The actual underlying problem here is a namespace conflict on
jmpbuf.  The _csi_scanner structure is not part of any public API, so how about
just renaming the member to jump_buffer?

[1]
http://stackoverflow.com/questions/2762568/c-c-include-file-order-best-practices

[2]
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Order_of_Includes

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cairographics.org/archives/cairo-bugs/attachments/20150305/c143260b/attachment.html>