[cairo-bugs] [Bug 91967] Assertion "(_cairo_atomic_int_get (&(&surface->ref_count)->ref_count) > 0)"

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=91967

--- Comment #32 from Bryce Harrington <b.harrington at samsung.com> ---
I can quibble over patch style but the fix seems on the right path - don't
destroy image->base if it wasn't created or was already destroyed.

What I'm not sure about is adding a second goto bail out point in the code. 
There are situations where bail outs are appropriate and add clarity to the
code, but this routine is so convoluted already I don't think that would be the
case here.

What about setting "image = NULL" after the destruction and then just adding an
"if (image)" before the cairo_surface_destroy call in BAIL?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cairographics.org/archives/cairo-bugs/attachments/20160616/1e1097bf/attachment.html>