[cairo-bugs] [Bug 91967] Assertion "(_cairo_atomic_int_get (&(&surface->ref_count)->ref_count) > 0)"

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=91967

Uli Schlachter <psychon at znc.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118325|0                           |1
        is obsolete|                            |

--- Comment #43 from Uli Schlachter <psychon at znc.in> ---
Created attachment 124589
  --> https://bugs.freedesktop.org/attachment.cgi?id=124589&action=edit
Proposed fix

Before this goes even more out of control: Anybody against this patch?

It should make Chris happy by saying that the caller still did something wrong
here, having the drawable freed from beneath cairo.
It should Bryce happy, because the possible-crash he worries about is handled.
Note that freeing both image and &image->base as proposed in comment 6 is
wrong, since &image->base is just a hidden pointer cast. Image is the
cairo_image_surface_t* and &image->base is the same thing as a
cairo_surface_t*.
It should make most reporters happy since it fixes the
double-cairo_surface_destroy that this book actually is about (sorry Jaroslav,
cairo is currently not meant to handle this case and your patch is incomplete
due to X11's asynchronous nature).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cairographics.org/archives/cairo-bugs/attachments/20160618/b02af598/attachment.html>