[cairo-bugs] [Bug 90318] TSan data races with freed_pool_t's |top| data member

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Mar 2 02:06:00 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=90318

--- Comment #4 from Wan-Teh Chang <wtc at google.com> ---
Comment on attachment 121989
  --> https://bugs.freedesktop.org/attachment.cgi?id=121989
Hack adding C11 atomics for setting pool->top

Review of attachment 121989:
-----------------------------------------------------------------

Hi Uli,

I've tested such a patch in
https://bugzilla.mozilla.org/show_bug.cgi?id=1161170#c4.
It works. I will attach a proper patch based on the GCC
__atomic builtin functions next.


Why did't I use C11 atomics in the patch I'm about
to attach? A new implementation of the
_cairo_atomic_xxx functions based on C11 atomics will
require changes to function prototypes because C11
distinguishes between the |atomic_int| and |int| types
whereas Cairo uses the cairo_atomic_int_t type for both
purposes.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cairographics.org/archives/cairo-bugs/attachments/20160302/9526357a/attachment.html>


More information about the cairo-bugs mailing list