[cairo-bugs] [Bug 104325] cairo 1.14.12 hangs in read_png called from cairo_image_surface_create_from_png_stream on malformed png

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=104325

--- Comment #4 from Orivej Desh <orivej at gmx.fr> ---
If I qualify `png_setjmp` with `inline`, it warns (thanks to -Winline):

cairo-png.c: In function ‘png_setjmp’:
cairo-png.c:163:1: warning: function ‘png_setjmp’ can never be inlined because
it uses setjmp [-Winline]
 png_setjmp (png_struct *png)
 ^~~~~~~~~~
cairo-png.c: In function ‘write_png’:
cairo-png.c:163:1: warning: inlining failed in call to ‘png_setjmp’: function
not inlinable [-Winline]
cairo-png.c:241:9: note: called from here
     if (png_setjmp (png))
         ^~~~~~~~~~~~~~~~
cairo-png.c: In function ‘read_png’:
cairo-png.c:163:1: warning: inlining failed in call to ‘png_setjmp’: function
not inlinable [-Winline]
 png_setjmp (png_struct *png)
 ^~~~~~~~~~
cairo-png.c:582:9: note: called from here
     if (png_setjmp (png)) {
         ^~~~~~~~~~~~~~~~

We are building with gcc 6.4.0 (and glibc 2.26). Does your version of gcc
inline it?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cairographics.org/archives/cairo-bugs/attachments/20171223/7712cc61/attachment.html>