[cairo-bugs] [Bug 103536] Windows filenames should be in UTF-8 encoding

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Nov 6 12:55:30 UTC 2017


Tom Schoonjans <Tom.Schoonjans at me.com> changed:

           What    |Removed                     |Added
 Attachment #135230|0                           |1
        is obsolete|                            |

--- Comment #9 from Tom Schoonjans <Tom.Schoonjans at me.com> ---
Created attachment 135258
  --> https://bugs.freedesktop.org/attachment.cgi?id=135258&action=edit
Windows UTF-8 patch

I think I addressed the comments with this new patch except the last suggestion
regarding using a for/while loop for the fopen mode. Though I agree that there
will be some overhead caused by using _cairo_utf8_to_utf16, I think that it's a
reasonable one, especially since these methods are unlikely to be called a lot
during the execution of a program.

I have also not gone ahead with replacing every occurrence in the source of
fopen to _cairo_fopen. Unless I missed one, the remaining ones are in DEBUG_*
sections only, and they are always passed ASCII string filenames, either
directly or indirectly.

You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cairographics.org/archives/cairo-bugs/attachments/20171106/bd28690d/attachment.html>

More information about the cairo-bugs mailing list