[cairo-bugs] [Bug 103559] Incorrect code generation for atomic operations if HAVE_INTEL_ATOMIC_PRIMITIVES defined

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Nov 16 23:11:36 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=103559

--- Comment #10 from Bill Spitzak <spitzak at gmail.com> ---
>From the referenced document, first line:

"The following built-in functions are intended to be compatible with those
described in the Intel Itanium Processor-specific Application Binary Interface,
section 7.4. As such, they depart from normal GCC practice by not using the
‘__builtin_’ prefix and also by being overloaded so that they work on multiple
types."

Sure sounds like they existed BEFORE gcc, still exist as the only option in
some other compilers, and thus "GCC legacy" is wrong in any documentation that
is not gcc-only. Cairo in theory can be compiled with ICC and that may require
turning this switch on.

To be honest I think most programmers familiar with these call them the
"__sync" functions, not "Intel" or "GCC" anything. But it still seems like the
comment could be improved.

My recomendation is to call the define HAVE_ICC_SYNC_PRIMITIVES or
HAVE_SYNC_PRIMITIVES.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cairographics.org/archives/cairo-bugs/attachments/20171116/c47ec91f/attachment.html>


More information about the cairo-bugs mailing list