[cairo-commit] src/cairo-xcb-screen.c

[Bryce Harrington]

 src/cairo-xcb-screen.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

New commits:
commit e0c0a673ee757615bd3d22f46767535e9f53d6f5
Author: Bryce Harrington <bryce at osg.samsung.com>
Date:   Wed Sep 17 17:14:01 2014 -0700

    Disable font options for xcb.
    
    This patch makes a bunch of tests pass again. The first hunk one fixes a
    shameful oversight (whoops), the second one effectively reverts
    e691d242.  That change broke 102 xcb and 70 xlib tests, including a
    bunch of *twin-antialias-* test cases.  Patch thanks to Uli Schlachter.
    
    Signed-off-by: Bryce Harrington <b.harrington at samsung.com>

diff --git a/src/cairo-xcb-screen.c b/src/cairo-xcb-screen.c
index 30295af..69ea459 100644
--- a/src/cairo-xcb-screen.c
+++ b/src/cairo-xcb-screen.c
@@ -242,6 +242,7 @@ _cairo_xcb_screen_get (xcb_connection_t *xcb_connection,
 
     screen->connection = connection;
     screen->xcb_screen = xcb_screen;
+    screen->has_font_options = FALSE;
 
     _cairo_freelist_init (&screen->pattern_cache_entry_freelist,
 			  sizeof (struct pattern_cache_entry));
@@ -460,7 +461,12 @@ _cairo_xcb_screen_get_font_options (cairo_xcb_screen_t *screen)
 	_cairo_font_options_init_default (&screen->font_options);
 	_cairo_font_options_set_round_glyph_positions (&screen->font_options, CAIRO_ROUND_GLYPH_POS_ON);
 
-	if (! _cairo_xcb_connection_acquire (screen->connection)) {
+	/* XXX: This is disabled because something seems to be merging
+	   font options incorrectly for xcb.  This effectively reverts
+	   the changes brought in git e691d242, and restores ~150 tests
+	   to resume passing.  See mailing list archives for Sep 17,
+	   2014 for more discussion. */
+	if (0 && ! _cairo_xcb_connection_acquire (screen->connection)) {
 	    _cairo_xcb_init_screen_font_options (screen);
 	    _cairo_xcb_connection_release (screen->connection);
 	}