[cairo] Error handling patch
otaylor at redhat.com
Wed Jul 27 16:24:14 PDT 2005
On Wed, 2005-07-27 at 16:14 -0700, Carl Worth wrote:
> On Wed, 27 Jul 2005 18:57:57 -0400, Owen Taylor wrote:
> > This last one was easy, as it turned out. The immediate callers were
> > still checking for NULL, and returning a status to the cache
> > code, so I just needed to make the functions return NULL again.
> Ah, good.
> > Attached patch look OK to commit?
> I don't think we should need the new _cairo_error calls. The return
> value should result in a final check and _cairo_error up close to the
> public interface, right?
> Other than that, (and at worst it's a doubled call to _cairo_error),
> yes, it looks fine.
Extra calls to _cairo_error() removed. I admit that I don't yet have
a good sense of style here. My guess is that _cairo_error(), is, in
any case most useful for errors *other than* out of memory.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/cairo/attachments/20050727/cdf297de/attachment.pgp
More information about the cairo