[cairo] [PATCH] Allow hash entry deletion during cairo_hash_foreach

Carl Worth cworth at cworth.org
Tue Apr 11 08:57:28 PDT 2006


On Mon, 10 Apr 2006 23:53:27 -0700, Keith Packard wrote:
> 
> Can I get this reviewed to see if I missed any relevant cases?
> 

That all looks good to me.

It may be worth throwing one of these:

	/* No iterators can be running. Otherwise, halt. */
	assert (hash_table->iterating == 0);

into _cairo_hash_table_resize itself. (The existing calls are already
guarded with your patch, but that would put the check at the lowest
level in case new calls to resize ever get added.)

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20060411/6f21fa71/attachment.pgp


More information about the cairo mailing list