[cairo] [PATCH] Allow hash entry deletion during
cairo_hash_foreach
Keith Packard
keithp at keithp.com
Tue Apr 11 10:41:37 PDT 2006
On Tue, 2006-04-11 at 08:57 -0700, Carl Worth wrote:
> On Mon, 10 Apr 2006 23:53:27 -0700, Keith Packard wrote:
> >
> > Can I get this reviewed to see if I missed any relevant cases?
> >
>
> That all looks good to me.
>
> It may be worth throwing one of these:
>
> /* No iterators can be running. Otherwise, halt. */
> assert (hash_table->iterating == 0);
I actually removed that check, but can put it back if you like.
>
> into _cairo_hash_table_resize itself. (The existing calls are already
> guarded with your patch, but that would put the check at the lowest
> level in case new calls to resize ever get added.)
>
> -Carl
--
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/cairo/attachments/20060411/552be70c/attachment.pgp
More information about the cairo
mailing list