[cairo] git "performance" patchset # 1 available + a few questions
Bertram Felgenhauer
bertram.felgenhauer at googlemail.com
Thu Aug 31 18:12:28 PDT 2006
David Turner wrote:
One nit:
[0001-changing-_cairo_fixed_to_double-into-a-macro.txt]
> + if ( p1->x == p2->x && p1->y && p2->y )
^^^^
> + return _cairo_spline_point_proximity( &base[1], p1, tolerance2) &&
> + _cairo_spline_point_proximity( &base[2], p2, tolerance2);
Should be '==' (the purpose of this test is to avoid a possible division
by 0 later, if the first and last control points are identical).
The rest of this patch looks fine.
[0002-modification-of-the-path-filler-to-use-_cairo_spline_decompose...]
This patch I really like.
I can't really comment on the others.
Regards,
Bertram Felgenhauer
More information about the cairo
mailing list