[cairo] Make check on OS/2 revisited

[Peter Weilbacher (Mozilla)]

Behdad Esfahbod wrote:
> On Tue, 2007-04-10 at 21:54 +0200, Peter Weilbacher (Mozilla) wrote:
>> On Mon, 09 Apr 2007 12:46:21 -0400, Behdad Esfahbod wrote:
>>
>>> On Mon, 2007-04-09 at 12:38 -0400, Dave Yeo wrote:
>>>> So I've solved the problem of make check failing on OS/2. Seems to be
>>>> the EXTRA_PROGRAMS declaration in test/Makefile.am. Changing it to
>>>> check_PROGRAMS like so
>>>>
>>>> --- Makefile.am.orig    Fri Mar  2 21:04:02 2007
>>>> +++ Makefile.am Mon Apr  9 09:33:18 2007
>>>> @@ -481,7 +481,7 @@
>>>>  svg2png_LDADD  = $(LDADD) $(LIBRSVG_LIBS)
>>>>  endif
>>>>
>>>> -EXTRA_PROGRAMS = $(TESTS) $(SUPPORT_PROGS)
>>>> +check_PROGRAMS = $(TESTS) $(SUPPORT_PROGS)
>>> There is a delicate reason for not using check_PROGRAMS here.  If this
>>> patch fixes your issues, it's definitely an automake bug.  Please poke
>>> them.
>> Care to elaborate on the "delicate" reason? I doubt that the automake
>> guys care about OS/2...
> 
> If we use check_PROGRAMS, then all tests are rebuilt before any testing
> can be done.  So, even if you do something like:
> 
> 	make test TESTS=dash-scale
> 
> It will rebuild all the tests.  That takes quite a while.  Instead, I
> used EXTRA_PROGRAMS which means each individual test will be built on
> demand.
> 
> Maybe you can at least patch automake and send them the patch before
> judging them.

Sure, I wasn't judging them. What I meant was that they probably don't
care enough to get OS/2 installed, test there and fix automake. I for
one don't even know where to start investigating. But now that you have
explained the difference, maybe I will be able to figure it out (when
I find time).

Cheers,
   Peter.