[cairo] Win32 makefiles patch

Daniel Amelang daniel.amelang at gmail.com
Tue Feb 13 22:49:24 PST 2007

On 2/13/07, Carl Worth <cworth at cworth.org> wrote:
> On Sun, 11 Feb 2007 03:41:43 -0800, "Daniel Amelang" wrote:
> > The Makefile.win32 makefiles are out-of-date. This patch makes cairo
> > compilable with then again. I also did some very minor work on the
> > "clean" rules.
> >
> > Good enough to push?
> I've got ahead and pushed this now.
> I was surprised to discover that the following commands:
>         chmod a-x src/Makefile.win32
>         git commit -a --amend
> were not sufficient to fix the inadvertent mode change. That looks
> like a git bug to me. But I fixed it by making a new branch instead.

I banged my head on this earlier today and thought it was a cygwin git
problem. Worked around it the same way as you did. I would have
committed it then but didn't have my private ssh key on my windows box
and freedesktop wasn't taking my password for some reason.

> Oh, you're using gmail? Were you avoiding attachments because it
> unconditionally puts them in base64 encoding or something?
> If so it sounds like you may have a lose-lose situation there, (either
> unreadable patch attachments or broken inline patches). :(

So it looks like gmail really isn't an option for contributing patches
to cairo. Unless the inline+attachment idea works.


More information about the cairo mailing list