[cairo] infinite loop when CAIRO_FIXED_FRAC_BITS is 8

Carl Worth cworth at cworth.org
Thu Feb 14 15:47:35 PST 2008

On Thu, 14 Feb 2008 18:27:20 -0500, Behdad Esfahbod wrote:
> > consistently, (though my analysis was probably too shallow).
> >
> > And for what it's worth, we *don't* call qsort with this comparison
> > function.
> We do, by way of _cairo_hull_vertex_compare().  I checked ;).

OK, so change "probably" above to "definitely". I blew this one.

And I'm glad I asked for review. Thanks for saving me on this one,

> I'd go with something like: "To break ties when comparing slope vectors
> with exactly pi angular difference, the vector with a positive dx (or
> positive dy if dx's are zero) is considered ..."

Perfect. I'll go with that.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.cairographics.org/archives/cairo/attachments/20080214/3169cb3a/attachment.pgp 

More information about the cairo mailing list