[cairo] X crash with BadAlloc with too-large pixmap

Vladimir Vukicevic vladimir at pobox.com
Wed Jul 9 16:11:30 PDT 2008

On Jun 30, 2008, at 4:28 PM, Behdad Esfahbod wrote:

> On Mon, 2008-06-30 at 10:32 -0700, Vladimir Vukicevic wrote:
>> Don't think I got a response last time -- any thoughts on this?  The
>> fix seems reasonable to me, though I'd probably change the function
>> name to _cairo_safe_XCreatePixmap or somesuch.
> Good to go.  Please file a bug against GTK+ too.

Slightly different patch, let me know if this works for you as well.   
I just added width/height checks where necessary, to avoid creating  
the helper function (and exposing it).  I'll file a bug against GTK+  
to audit XCreatePixmap calls.

    - Vlad

-------------- next part --------------
A non-text attachment was scrubbed...
Name: cairo-xcreatepixmap-size.patch
Type: application/octet-stream
Size: 3616 bytes
Desc: not available
Url : http://lists.cairographics.org/archives/cairo/attachments/20080709/18380ff7/attachment.obj 
-------------- next part --------------

More information about the cairo mailing list