[cairo] Pushing vmx patches in pixman

[Luca Barbato]

Soeren Sandmann wrote:
> The remaining comments I have:
> 
>         +pixman_bool_t pixman_have_vmx (void) {
>         +    if (!initialized) {
>         +        signal(SIGILL, vmx_test);
>         +        asm volatile ( "vor 0, 0, 0" );
>         +        signal(SIGILL, SIG_DFL);
>         +        initialized = TRUE;
>         +    }
>         +    return have_vmx;
>         +}
> 
> This will reset any signal handler the application itself may have
> set. It would be better to us sigaction() and restore the old handler
> instead of using SIG_DFL. Doing that still leaves a race where another
> thread could change the signal handler while pixman was initializing,
> but I think that's unlikely enough to be ok.

I'll do that soon

> Finally, I'd still like to see the fbByteMul() macros being generated
> into their own header file, and then #included in both
> pixman-combine{32,64}.c and pixman-vmx.c.

There are some definitions duplicated in the sources, should I replace 
them as well?

lu

-- 

Luca Barbato
Gentoo Council Member
Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero