[cairo] GSoC: Scan converting rasteriser update

Jeff Muizelaar jeff at infidigm.net
Tue Nov 11 06:03:12 PST 2008

On Sat, Nov 08, 2008 at 04:53:17PM -0500, Jeff Muizelaar wrote:
> And some initial review of the cairo-spans changes:

Here's some more:

[cairo-spans] Hook up filling paths with spans to cairo-surface-fallback.c.
- the region optimizations should probably be moved up out of
  _clip_and_composite_trapezoids() so that conditionally taking that path is no
  longer necessary. i.e. we should try to region filling if that fails
  we should take either the trapezoid path or the spans path. Don't worry
  about doing this know, just put a TODO: with a description of what needs to
  be done.

- _composite_spans_fill_func:
  - when is this called without a source pattern? It's probably useful
    to put this in the comment.
  - the 'if (NULL == src)' test should be changed to 'if (!src)'
  - the second call to _cairo_surface_make_span_renderer() are a little awkward
    but I wouldn't worry about that until we do the interface refactoring.
    Perhaps just add a comment.

More information about the cairo mailing list