[cairo] Not using libpng on OSX
vladimir at pobox.com
Fri Sep 12 14:37:51 PDT 2008
On Sep 12, 2008, at 7:52 AM, Behdad Esfahbod wrote:
> Nice work.
Yep, the code looks good -- I'll give it a more detailed lookover soon.
> It depends on the Quartz surface it seems. Is that correct? That
> changes how
> configuration should be done.
> In general, right now we don't have much way to deal with
> conditional file
> inclusions other than C preprocessor conditionals. The constraint
> comes from
> wanting to keep the configuration central and shared, and the fact
> conditional syntax is different between autotools and win32. I may
> something today. Even more build system hacking. I love that!
One thing we could do to simplify this is just do #ifdef
CAIRO_PNG_USE_LIBPNG in cairo-png.c, and #ifdef CAIRO_PNG_USE_CGIMAGE,
CAIRO_PNG_USE_WIN32 etc.. and just compile all of them, and do the
conditionals in cairo-features.h. But maybe you'd enjoy the build
system hacking more :)
> Travis Griggs wrote:
>> Attached is a patch, which makes an OS X build not need libpng, but
>> instead use the CoreFoundation services provided by OSX. It's a new
>> file, and a change to the Makefile.sources (ideally, this second
>> be made conditional). I also go in to my Makefile after
>> and whitewash any libpng references and cairo-png.c references, so
>> sure it builds/links without them.
>> The tests all run and don't completely melt down. I think we always
>> a decent amount of failures on OSX to begin with.
>> I guess the next thing I need to do is figure out how to wire it into
>> the Makefile.am stuff. Any help/hints/etc appreciated. If I can
>> that out, I'll try to submit the more complete patch. But I figured
>> post this much, in the event, I'm unable to make much traction with
>> other part. Or in the event it's better done by someone else anyway.
>> BTW, thanks much to numerous IRCers for all the help with this.
>> Travis Griggs
>> For every adage, there is an equal and contrary un-adage
>> cairo mailing list
>> cairo at cairographics.org
> cairo mailing list
> cairo at cairographics.org
More information about the cairo