[cairo] Not using libpng on OSX

Behdad Esfahbod behdad at behdad.org
Fri Sep 12 15:33:10 PDT 2008


Vladimir Vukicevic wrote:
> On Sep 12, 2008, at 7:52 AM, Behdad Esfahbod wrote:
> 
> One thing we could do to simplify this is just do #ifdef  
> CAIRO_PNG_USE_LIBPNG in cairo-png.c, and #ifdef CAIRO_PNG_USE_CGIMAGE,  
> CAIRO_PNG_USE_WIN32 etc.. and just compile all of them, and do the  

Yes, that's what I said using preprocessor does.

> conditionals in cairo-features.h.  But maybe you'd enjoy the build  
> system hacking more :)

No cairo-features.h support needed.  All various implementations are under the
HAS_PNG_FUNCTIONS.

behdad


>     - Vlad
> 
>> Travis Griggs wrote:
>>> Attached is a patch, which makes an OS X build not need libpng, but
>>> instead use the CoreFoundation services provided by OSX. It's a new
>>> file, and a change to the Makefile.sources (ideally, this second  
>>> should
>>> be made conditional). I also go in to my Makefile after  
>>> configure'ing,
>>> and whitewash any libpng references and cairo-png.c references, so  
>>> I'm
>>> sure it builds/links without them.
>>>
>>> The tests all run and don't completely melt down. I think we always  
>>> have
>>> a decent amount of failures on OSX to begin with.
>>>
>>> I guess the next thing I need to do is figure out how to wire it into
>>> the Makefile.am stuff. Any help/hints/etc appreciated. If I can  
>>> figure
>>> that out, I'll try to submit the more complete patch. But I figured  
>>> I'd
>>> post this much, in the event, I'm unable to make much traction with  
>>> this
>>> other part. Or in the event it's better done by someone else anyway.
>>>
>>> BTW, thanks much to numerous IRCers for all the help with this.
>>>
>>> -- 
>>> Travis Griggs
>>> Objologist
>>> For every adage, there is an equal and contrary un-adage
>>>
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> _______________________________________________
>>> cairo mailing list
>>> cairo at cairographics.org
>>> http://lists.cairographics.org/mailman/listinfo/cairo
>> _______________________________________________
>> cairo mailing list
>> cairo at cairographics.org
>> http://lists.cairographics.org/mailman/listinfo/cairo
> 
> _______________________________________________
> cairo mailing list
> cairo at cairographics.org
> http://lists.cairographics.org/mailman/listinfo/cairo
> 


More information about the cairo mailing list