[cairo] [cairo-commit] 5 commits - src/cairo-xlib-surface.c

Carl Worth cworth at cworth.org
Tue Sep 30 16:29:33 PDT 2008

On Tue, 2008-09-30 at 14:56 -0700, Behdad Esfahbod wrote:
>     [xlib] Start a new glyph element every 128 glyphs
>     Xrender has limits at 252 glyphs.  We play safe and fast and limit
>     elements to 128 glyphs.  That's plenty, no measurable performance
>     hit expected.
>     [xlib] Allow room for glyph element padding
>     Xrender pads glyph elements to 4byte boundaries.  We didn't consider
>     that in our request size calculations.  We do now.
>     [xlib] Add comment about glyph chunk invariant
>     Revert "[xlib] Correct calculation of XRenderComposite* request size."
>     This reverts commit 0eb0c26474a19477554bfd580aa5f8ae77c29779.
>     The change was too drastic and overlooked some subleties of the old
>     code, but the main reason for the revert is that it introduced an
>     ugly duplicated glyph flush block.  I'm working on a more incremental
>     fix.

A lovely cleanup, Behdad!

And thanks for doing this code review---it's really appreciated.

I do wonder if we shouldn't get in the habit of explicitly asking for
such review more rather than just pushing code out and hoping that 
people watch it (and clean it up if necessary).


More information about the cairo mailing list