[cairo] [PATCH] A set of NEON blitters for Pixman.

Jonathan Morton jonathan.morton at movial.com
Thu Jun 4 05:18:02 PDT 2009


> > Ah, I see the real bug.  It's a one-liner - r5 is being sourced
> > explicitly instead of the %[width] reference.  It's probably a
> > copy-paste bug, not spotted because I didn't originally write it.
> 
> This small piece of code actually happened to have two bugs. In addition to
> using r5 register incorrectly, it just does not advance the destination
> pointer (r4 register).

Ah.  I'd forgotten about that subtlety - that the NEON addressing modes
are more like LDMIA/STMIA addressing modes, and that LDR/STR are
different.

The two patches attached should, together, fix the problem finally.

-- 
------
From: Jonathan Morton
      jonathan.morton at movial.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0041-Fix-filler-bug.patch
Type: text/x-patch
Size: 0 bytes
Desc: not available
Url : http://lists.cairographics.org/archives/cairo/attachments/20090604/490a8f83/attachment-0002.bin 


More information about the cairo mailing list