[cairo] [PATCH] A set of NEON blitters for Pixman.

Koen Kooi k.kooi at student.utwente.nl
Thu Jun 4 07:57:04 PDT 2009

On 04-06-09 14:18, Jonathan Morton wrote:
>>> Ah, I see the real bug.  It's a one-liner - r5 is being sourced
>>> explicitly instead of the %[width] reference.  It's probably a
>>> copy-paste bug, not spotted because I didn't originally write it.
>> This small piece of code actually happened to have two bugs. In addition to
>> using r5 register incorrectly, it just does not advance the destination
>> pointer (r4 register).
> Ah.  I'd forgotten about that subtlety - that the NEON addressing modes
> are more like LDMIA/STMIA addressing modes, and that LDR/STR are
> different.
> The two patches attached should, together, fix the problem finally.
I applied 0041-Fix-filler-bug.patch and 0042-Really-fix-filler-bug.patch 
to 3c570a815afb282df01f41acad385ff0e3e33899 and I get:


Which looks OK :) Many thanks for your and Siarheis patches!



More information about the cairo mailing list