[cairo] [1.10.0] Windows compatibility?

[Maarten Bosmans]

2010/9/8 Cxx Joe <cxxjoe at googlemail.com>:
> Hey guys,
>
> congratulations on launching 1.10.0.
>
> I ran into two problems when building on Windows (Visual Studio 2008,
> GNU Make 3.81):
>
> 1) Invalid "if" constructs in src/Makefile.sources.
> Fixed that using
> sed "s/^if \([A-Z_]*\)$/ifeq ($(\1), 1)/" src\Makefile.sources

May be '/ifdef \1/' would be a better fix? Although I did see your
style in other files like Makefile.win32.features.

> 2) _lround is not available on Windows/MSVC.
> Worked around that using
> sed "s/#define _cairo_lround lround/static inline long cairo_const
> _cairo_lround(double r) { return (long)floor(r + .5); }/"
> (which is probably a poor fix)

Could you rework that to use a macro definition, so that your lround
isn't used on non-MSVC builds?

> These issues aside, everything works great (for both x86 and x86_64
> architectures).
>
> Any thoughts?

My experience is that the list is a bit more responsive if you offer
concrete patches to review.

> Thanks!
> Joe

Maarten