[cairo] [PATCH] gl: Fix bug in render_glyphs_via_mask().

Chuanbo Weng strgnm at gmail.com
Tue Jun 26 01:06:00 PDT 2012


agree with you.
I saw the patch you committed:
185a3518968d5ca0babb798fe10f247171a1e001
Just a slight modification is needed, I think:
The dst_x and dst_y should be considered when
trimming the mask.

2012/6/20 Chris Wilson <chris at chris-wilson.co.uk>

> On Wed, 20 Jun 2012 04:04:43 +0800, Chuanbo Weng <strgnm at gmail.com> wrote:
> > If the operator is unbounded and mask is not large enough, the area
> > affected by _cairo_surface_mask() in render_glyphs_via_mask() will
> > be too larger, then result in output error. Fixes overlapping-glyphs
> > and unbounded-operator test cases in cairo-test-suite.
>
> Whoops, the error here is that we have begun to pass in a NULL clip to
> _cairo_surface_mask(), which as you can see has the effecting of
> clearing everything outside of the masked region.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cairographics.org/archives/cairo/attachments/20120626/8fd35a86/attachment.html>


More information about the cairo mailing list