[cairo] [PATCH] gl: Fix bug in render_glyphs_via_mask().

Chris Wilson chris at chris-wilson.co.uk
Tue Jun 26 02:03:16 PDT 2012


On Tue, 26 Jun 2012 16:06:00 +0800, Chuanbo Weng <strgnm at gmail.com> wrote:
> agree with you.
> I saw the patch you committed:
> 185a3518968d5ca0babb798fe10f247171a1e001
> Just a slight modification is needed, I think:
> The dst_x and dst_y should be considered when
> trimming the mask.

Yes, I do believe you are right. Since dst may no longer be
info->surface, and so require the offset.

Can you see if that fixes any test cases, or devise one to exercise this
failure path? It should be required for a clipped source/unbounded
operation.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the cairo mailing list