[cairo] [PATCH 2/3] Support a different pixel format for HDC

[Uli Schlachter]

Am 26.03.2015 um 20:44 schrieb LRN:
> On 11.03.2015 0:31, Bryce Harrington wrote:
>> On Tue, Mar 10, 2015 at 05:52:07PM +0300, LRN wrote:
>>>>
>>>> Patch #1 is from cairo bugzilla, see the link you gave me in [1].
>>>>
>>>> Patch #2 (this patch) was used by Mozilla[2] back in 2010. They have [had?]
>>>> internal copy of cairo to patch, so maybe they just haven't bothered with
>>>> submitting it. Or maybe they did submit it to cairo bugzilla and it got lost
>>>> there. Who knows? Either way, the patch is trivial enough, so i wouldn't
>>>> worry about this one too much.
>>>>
>>>>
>>>> [1] http://lists.cairographics.org/archives/cairo/2014-April/025148.html
>>>> [2] https://bugzilla.mozilla.org/show_bug.cgi?id=577200
>>>>
>>>
>>> Any progress on this?
>>>
>>> The fallback surface-related crash was fixed in 0.14, so the patch labeled "Enlarge fallback surface" is no longer necessary. I would only need this patch ("Support a different pixel format for HDC") and at least one bit from "Adjust assertions and checks to handle more pixel formats".
>>>
>>> These patches are very small, the only prerequisite for being able to evaluate them is understanding of cairo and W32 API. I'd very much like to stop patching cairo and push Windows RGBA code into GTK.
>>>
>>
>> Mind extracting whatever bits are still needed, into new patches?
>> Please use git format-patch against cairo trunk for creating them.
>>
> 
> Here they are.
> 
> Do i need to send each one as a separate email (not an as an attachment) as well?

We talked about these patches a bit on IRC. I have no clue about win32, but LRN
and Google managed to convince me that this might make sense. It would be great
if this were covered by the test suite, but the cairo_win32_surface_create()
function isn't covered either (the source code claims that this doesn't make
sense and the existing *_dib() boilerplate is enough).

So this has my +1, although I would prefer if someone with some actual clue
about win32 would look over this and say that this API makes sense.

Cheers,
Uli
-- 
99 little bugs in the code
99 little bugs in the code
Take one down, patch it around
117 little bugs in the code
  -- @irqed