[cairo] [PATCH 14/41] drm/intel: intel_scaled_glyph_fini(): renamed local priv variable for better consistency
psychon at znc.in
Sat Dec 12 01:53:22 PST 2015
Am 12.12.2015 um 06:23 schrieb Enrico Weigelt, metux IT consult:
> On 11.12.2015 17:51, Uli Schlachter wrote:
>> Uhm, this patch doesn't do at all what the commit message claims it does. I
>> don't see why removing this NULL check is safe and I think it's the more
>> important change than renaming the variable.
> It's just to make it more consistent with the naming scheme used in
> other backends (eg. gl). I've done it in a separate patch to keep the
> individual changes small, for easier review (and later reading)
I can see that, yeah. However, this still removes the if (glyph != NULL) check
that was there before (should be priv != NULL after this patch, no?).
Bruce Schneier can read and understand Perl programs.
More information about the cairo