[cairo] OpenType font variations and cairo

[Behdad Esfahbod]

+Khaled,Werner

Two things:

  * Werner, please please please remove code that change face->face_index.
It's bad bad bad.

  * With Matthias's branch, we break Khaled's code, ie. if user creates
FT_Face, sets variations on it, and creates cairo_face_t from, we reset /
ignore those variations.  The fix would require savings the variations that
were on the face when face was created, and use those instead of
instance-defaults in apply_variations().  Matthias, any chance you can do
this?

b

On Thu, Sep 28, 2017 at 7:01 PM, Behdad Esfahbod <behdad.esfahbod at gmail.com>
wrote:

> On Thu, Sep 28, 2017 at 6:09 PM, Adrian Johnson <ajohnson at redneon.com>
> wrote:
>
>> On 29/09/17 06:06, Matthias Clasen wrote:
>> I pulled your latest changes and tested with various combinations of
>> freetype and fontconfig - see below. All good on the cairo side, except
>> for the build fail with FT 2.6.3 but I mentioned that needs fixing in my
>> review comments.
>>
>> There appears to be a bug in fontconfig master when using freetype 2.8.
>>
>> If you cleanup and rebase your commits to master with all review
>> comments addressed, I'll do a final check and then it should be good to
>> commit.
>>
>
> Thanks Adrian for all the help.
>
> freetype 2.6.3: build failed - FT_Get_Var_Design_Coordinates not found
>>
>> freetype 2.8, fontconfig 2.11.0 : pass
>>
>> freetype 2.8, fontconfig 2.12.5 : pass
>>
>> freetype 2.8, fontconfig master :
>>
>> When running the fc-cache built from master I get:
>>   fc-cache: fcfreetype.c:2143: IA__FcFreeTypeQueryAll: Assertion
>>   `mm_var' failed.
>>
>> fc-cache succeeds after removing AdobeVFPrototype.ttf from ~/.fonts
>>
>> I tried again with AdobeVFPrototype.otf. fc-cache ran successfully and
>> the cairo test passed.
>>
>
> Humm.  This sounds very much like what might happen with old FreeType . If
> not, can you elaborate what happens again?  Can you reproduce?  What
> FreeType exactly?   Does `fc-query AdobeVFPrototype.ttf` work?
>
> I can probably replace assert with a less harsh mode of failure.
>
>
>
>> freetype 2.8.1, fontconfig 2.11.0 : pass
>>
>> freetype 2.8.1, fontconfig 2.12.5 : pass
>>
>> freetype 2.8.1, fontconfig master : pass
>>
>> freetype master, fontconfig master : pass
>>
>>
>>
>>
>>
>>
>
>
> --
> behdad
> http://behdad.org/
>



-- 
behdad
http://behdad.org/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cairographics.org/archives/cairo/attachments/20170928/33353ea7/attachment.html>