[cairo] [PATCH] OS/2 surface fixes
M Joonas Pihlaja
jpihlaja at cc.helsinki.fi
Sun Aug 8 23:19:33 PDT 2010
On Sun, 8 Aug 2010, Rich Walsh wrote:
> > we'll push to master
> That would be greatly appreciated.
... and they've landed now.
> >>*os2_regression.diff - patch bed2701..f3dda3c removed a block of code
> > This is the only patch that IMHO doesn't need to be applied.
> I'm sure you are correct that neither that function nor any other
> really needs the surface type check. However, I suspect that anyone
> else looking at the current code would think - like I did - that
> there's an error because the type is checked in every other function
> except that one.
Yeah, there are a bunch of functions that have extraneous checks.
The rule is that public functions needs to check the surface type and
that the surface hasn't been finalized, but internal surface methods
like the _get_extents or _mark_dirty_rectangle functions don't need
More information about the cairo