[cairo] cairo-1.13 finally opens
Bryce W. Harrington
b.harrington at samsung.com
Thu Sep 5 12:07:48 PDT 2013
On Thu, Sep 05, 2013 at 06:42:38PM +0000, Henry (Yu) Song - SISA wrote:
> Hi, Bryce
>
> Good points on your comments. It is short on test cases on shadow and blur. If you can help on that would be great. The branch is a fork work, sorry about the messy commits. It contains 4 major enhancements: gaussian blur, shadow, glesv3 and glesv2 with GL_ANGLE msaa extensions, pus fix bugs/optimzation here and there.
>
How interdependent are those four chunks? I.e. could the
gaussian blur bits be split into its own branch and
reviewed/stabilized/landed first, then the others in turn? Or would
this require a lot of patch fiddling to extract it? Just trying to
think how to divide and conquer efficiently. :-)
And yeah, I can definitely help on test cases for shadow and blur.
Figure we'll want both functional tests and some perf tests.
Bryce
> ________________________________________
> From: Bryce W. Harrington
> Sent: Thursday, September 05, 2013 11:37 AM
> To: Henry (Yu) Song - SISA
> Cc: cairo at cairographics.org
> Subject: Re: [cairo] cairo-1.13 finally opens
>
> On Thu, Sep 05, 2013 at 03:54:43PM +0000, Henry (Yu) Song - SISA wrote:
> > Hi, Chris
> >
> > I have added Guassian blur and shadow support in cairo. It is available in filters-wip branch from https://github.com/SRA-SiliconValley/cairogles
> >
> > The gaussian blur and shadow support are available for GL/GLES, image, xcb and quartz backend.
> >
> > features in filters-wip
> >
> > 1. synced with cairo-1.12.14
> > 2. gaussian blur for gl/gles, image, xcb and quartz backends
> > 3. gl msaa compositor supports GL, GLESv3
> > 4. gl msaa compositor supports GLESv2 with the following three extensions: GL_EXT_multisampled_render_to_texture, GL_IMG_multisampled_render_to_texture, and GL_ANGLE_multisample_framebuffer/GL_ANGLE_framebuffer_blit
> > 5. support both drop shadow and inset shadow for gl/gles, image, xcb and quartz backends
> > 6. support shadow caching
> > 7. support custom shadow (e.g., you can draw arbitrary shadow path)
>
> I count about 180 individual patches on this branch (although maybe some
> are already merged?) Would the strategy for integrating this branch be
> to merge it, and then review and fix any remaining details in master, or
> to split the changes up into smaller patchsets for tighter review? Or...?
>
> In any case, I've been tinkering a bit with this branch, and I'd be
> happy to help on any grunt work needed here.
>
Bryce
More information about the cairo
mailing list