[cairo] Any plan to address the 32768px limit ?
Stanisław Jeśmanowicz
stan at jesmanowicz.com
Sat Jul 24 12:29:17 UTC 2021
Hello,
Referring to my previous patch :https://lists.cairographics.org/archives/cairo/2020-August/029019.html
I have replaced this with other patch on my local computes (see the attachment).
Basically, I have removed function _cairo_image_surface_is_size_valid() and all code related to it.
The reason? pixman library makes such tests every time.
Let them decide what is valid and what not.
Regards,
Stanislaw Jesmanowicz
On 7/24/21 10:52 AM, Uli Schlachter wrote:
> Hi again,
>
> Am 24.07.21 um 10:24 schrieb Uli Schlachter:
>> Am 23.07.21 um 23:29 schrieb ChameleonScales:
> [...]
>>> Otherwise could the source code be easily edited to make a custom build of Cairo with an increased limit?
>> Well, not easily, I guess.
> I just remembered that there might be a way: [0]
>
> If I understand this mail correctly, just dropping this check works good
> enough for some cases. So, if you want to make a custom build, you could
> just apply the patch from [0] and see what happens.
>
> Note that I do not have much trust in this patch. Subtle example: The
> patch from that mail multiplies two ints and then casts the result to
> uint64_t. Any integer overflows would already happen before the cast.
>
> Cheers,
> Uli
>
> [0]: https://lists.cairographics.org/archives/cairo/2020-August/029019.html
--
__________________________________________________________
Stanislaw Jesmanowicz stan <at> mail2 <dot> jesmanowicz <dot> com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cairographics.org/archives/cairo/attachments/20210724/c16b8a87/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cairo-1.17.3.patch
Type: text/x-patch
Size: 4082 bytes
Desc: not available
URL: <https://lists.cairographics.org/archives/cairo/attachments/20210724/c16b8a87/attachment.bin>
More information about the cairo
mailing list